|
Message-ID: <20120401113110.GC2371@gremlin.ru>
Date: Sun, 1 Apr 2012 15:31:10 +0400
From: gremlin@...mlin.ru
To: owl-dev@...ts.openwall.com
Subject: Re: hdparm update
On 01-Apr-2012 14:03:42 +0300, Mesut Can G?rle wrote:
> I prepared a patch to hdparm.spec for new version of hdparm 9.39
> and installation of wiper.sh. All files can be accessible from
> http://mesutcang.net23.net/owl/hdparm/. I successfully build and
> install the package. It seems to work. You can inspect the content.
> I am waiting for your reviews or new task.
> install -pD -m644 hdparm.8 %buildroot%_mandir/man8/hdparm.8
> +install -m 755 wiper/wiper.sh $RPM_BUILD_ROOT/sbin
Why do you use $RPM_BUILD_ROOT instead of %buildroot? Nothing wrong
with that, but it's better to keep the uniformity.
Also, possibly it makes sence to put wiper into separate %package
named hdparm-wiper or whatever.
--
Alexey V. Vissarionov aka Gremlin from Kremlin
<gremlin ПРИ gremlin ТЧК ru>
GPG key ID: 0xEF3B1FA8, keyserver: hkp://subkeys.pgp.net
GPG key fingerprint: 8832 FE9F A791 F796 8AC9 6E4E 909D AC45 EF3B 1FA8
Content of type "application/pgp-signature" skipped
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.