Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120401111626.GA5576@openwall.com>
Date: Sun, 1 Apr 2012 15:16:26 +0400
From: Solar Designer <solar@...nwall.com>
To: owl-dev@...ts.openwall.com
Subject: Re: hdparm update

On Sun, Apr 01, 2012 at 02:03:42PM +0300, Mesut Can G?rle wrote:
> I prepared a patch to hdparm.spec for new version of hdparm 9.39 and
> installation of wiper.sh. All files can be accessible from
> http://mesutcang.net23.net/owl/hdparm/. I successfully build and install
> the package. It seems to work. You can inspect the content.

Thank you!

I was about to suggest that we check where Red Hat's distros install
wiper.sh and consider using the same location (avoid unneeded
differences), but surprisingly they don't appear to package this script.

http://pkgs.fedoraproject.org/gitweb/?p=hdparm.git;a=tree

It is very nice that you noticed and added the wiper/README.txt file as
well.

Instead of:

install -m 755 wiper/wiper.sh $RPM_BUILD_ROOT/sbin

we'd normally use something like:

install -p -m755 wiper/wiper.sh %buildroot/sbin/

(BTW, the existing "install" lines unnecessarily list the filenames
twice - this may be corrected.)

> I am waiting for your reviews or new task.

I'll provide a new task separately.

Thanks again,

Alexander

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.