[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Z6bwxTqJwtoq6J1O@pie.lan>
Date: Sat, 8 Feb 2025 05:51:01 +0000
From: Yao Zi <ziyao@...root.org>
To: musl@...ts.openwall.com
Subject: Re: [RESEND PATCH] ldso: don't reclaim zero-memory-sized
segments
On Mon, Nov 18, 2024 at 03:44:47AM +0000, Yao Zi wrote:
> Some weird linkers may emit PT_LOAD segments with memsz = 0. ELF
> specification does not forbid this, but such a segment with non-zero
> p_vaddr will result in reclaiming of invalid memory address.
>
> This patch skips such segments during reclaiming for better
> compatibility.
Ping on this patch, someone has been hitting this[1].
Thanks for your time and review!
> Signed-off-by: Yao Zi <ziyao@...root.org>
> ---
> ldso/dynlink.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/ldso/dynlink.c b/ldso/dynlink.c
> index 3b57c07f..715948f4 100644
> --- a/ldso/dynlink.c
> +++ b/ldso/dynlink.c
> @@ -616,6 +616,7 @@ static void reclaim_gaps(struct dso *dso)
> for (; phcnt--; ph=(void *)((char *)ph+dso->phentsize)) {
> if (ph->p_type!=PT_LOAD) continue;
> if ((ph->p_flags&(PF_R|PF_W))!=(PF_R|PF_W)) continue;
> + if (ph->p_memsz == 0) continue;
> reclaim(dso, ph->p_vaddr & -PAGE_SIZE, ph->p_vaddr);
> reclaim(dso, ph->p_vaddr+ph->p_memsz,
> ph->p_vaddr+ph->p_memsz+PAGE_SIZE-1 & -PAGE_SIZE);
> --
> 2.46.0
>
[1]: https://lists.nongnu.org/archive/html/tinycc-devel/2024-10/msg00012.html
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
