[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20180419191152.GM3094@brightrain.aerifal.cx>
Date: Thu, 19 Apr 2018 15:11:52 -0400
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: tcmalloc compatibility
On Thu, Apr 19, 2018 at 08:27:44PM +0200, Szabolcs Nagy wrote:
> * Rich Felker <dalias@...c.org> [2018-04-18 16:35:56 -0400]:
> > Today I pushed changes which should make malloc
> > replacement/interposition work reliably as long as you only use
> > AS-safe functions. If you try this, please let us know how it turns
> > out and if you run into any unexpected problems.
>
> there was a report on irc that this change in memalign has falsepositives:
>
> - if (len > SIZE_MAX - align) {
> + if (len > SIZE_MAX - align || free != __internal_free) {
>
> in particular &free can point to a plt entry in the main executable
> while &__internal_free is in libc.so so they compare unequal.
Indeed, this will need to be reworked. I'll probably remove these
checks for now so that git master is not broken.
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
