Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140802163743.GS1674@brightrain.aerifal.cx>
Date: Sat, 2 Aug 2014 12:37:43 -0400
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: reserved symbol violations

On Sat, Aug 02, 2014 at 06:28:03PM +0200, Jens Gustedt wrote:
> Hi,
>  by digging into the symbols that are dragged into a C11 thread
> executable I noticed that there are some hotspots that should perhaps
> be worth looking at. I attach a file that summarizes the findings.
> 
> One is simple, I'd change the reference to clock_gettime in
> __timedwait to __clock_gettime.

That's fine.

> One looks weird, though, lock_ptc.o It is only linked (via __synccall)
> if setrlimit or setxid are. But then it drags a whole bunch of pthread
> symbols in, which looks wrong to me. Also I think that this doesn't
> really capture the need, because the code is only active if both
> setrlimit *and* pthread_create are *used*.
> 
> So in the absence of either of it, __syncall shouldn't be linked. But
> I wouldn't know how to achieve this with weak symbols, I have to
> admit.

I have no idea how to make it get linked only if both are used, and I
suspect it's impossible. However, there's no namespace violation here;
setrlimit and set*id are from POSIX, not ISO C. So it's just excess
bloat.

Rich

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.