[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAD-J=zaLVR1a+PYG38pRi0kyNLfaMwUfQTgj1mKUxPP=c9FLhQ@mail.gmail.com>
Date: Sun, 20 Jul 2014 03:17:27 +0400
From: Glauber Costa <glommer@...udius-systems.com>
To: Rich Felker <dalias@...c.org>
Cc: musl@...ts.openwall.com
Subject: Re: [PATCH] implement glibc's glob_pattern_p
On Sun, Jul 20, 2014 at 12:11 AM, Rich Felker <dalias@...c.org> wrote:
> On Thu, Jul 17, 2014 at 01:12:55PM +0400, Glauber Costa wrote:
> > Currently, glob is implemented but glob_pattern_p is not. This function
> > can trivially be implemented with existing glob machinery, since all it
> > does is to tell whether or not the string contains special symbols. This
> > is basically the same logic as is_literal, but with inverted return
> value.
> >
> > The value of the "quote" parameter should also be inverted, since the man
> > page states that when the quote parameter is *non*-zero, then backslashes
> > are ignored. is_literal ignores them when useesc is *zero*.
>
> I don't where this function would meet any of the criteria for
> exclusion, and so it looks like a candidate to add. Are there many
> programs that need it? What is the motivation for adding it?
>
> I found this missing symbol while running the rpm binary. I would not say
there are many programs using it.
It's the first time I hit it.
> BTW thanks for making the patch clean and using weak_alias right.
>
My pleasure.
Content of type "text/html" skipped
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
