[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140719201108.GA4739@brightrain.aerifal.cx>
Date: Sat, 19 Jul 2014 16:11:08 -0400
From: Rich Felker <dalias@...c.org>
To: Glauber Costa <glommer@...udius-systems.com>
Cc: musl@...ts.openwall.com
Subject: Re: [PATCH] implement glibc's glob_pattern_p
On Thu, Jul 17, 2014 at 01:12:55PM +0400, Glauber Costa wrote:
> Currently, glob is implemented but glob_pattern_p is not. This function
> can trivially be implemented with existing glob machinery, since all it
> does is to tell whether or not the string contains special symbols. This
> is basically the same logic as is_literal, but with inverted return value.
>
> The value of the "quote" parameter should also be inverted, since the man
> page states that when the quote parameter is *non*-zero, then backslashes
> are ignored. is_literal ignores them when useesc is *zero*.
I don't where this function would meet any of the criteria for
exclusion, and so it looks like a candidate to add. Are there many
programs that need it? What is the motivation for adding it?
BTW thanks for making the patch clean and using weak_alias right.
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
