[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAEXv5_jma18vzjjkW4DXV852BXXu9hipDXi4B3yYaB=684ox0w@mail.gmail.com>
Date: Fri, 10 Feb 2017 09:44:04 -0500
From: David Windsor <dwindsor@...il.com>
To: Kees Cook <keescook@...omium.org>
Cc: "kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>,
Peter Zijlstra <peterz@...radead.org>, "Reshetova, Elena" <elena.reshetova@...el.com>,
Hans Liljestrand <ishkamiel@...il.com>
Subject: Re: [PATCH] refcount: add refcount_t API kernel-doc comments
On Tue, Feb 7, 2017 at 7:49 PM, Kees Cook <keescook@...omium.org> wrote:
> On Tue, Feb 7, 2017 at 3:56 PM, David Windsor <dwindsor@...il.com> wrote:
>> This adds kernel-doc comments for the new refcount_t API. Additional feature documentation can go in
>> Documentation/security, if needed.
>
> Very cool. This may need to get rebased to Peter's lastest series
> (which uses REFCOUNT_WARN rather than WARN).
>
> Please add a "Signed-off-by:" line as well.
>
> I think it'd also be valuable to have some documentation describing
> how to actually use these, similar to your Examples section on the
> wiki.
>
I just submitted v2 of this documentation patchset, which adds
refcount_t API kernel-doc comments to include/linux/refcount.h.
I'll add some language to Documentation/security/self-protection.txt,
documenting the feature's justification, typical usage examples, etc.
This location was decided upon in an earlier discussion on this
mailing list.
Thanks,
David
> -Kees
>
> --
> Kees Cook
> Pixel Security
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
