Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAGXu5jKVsT19LuN4qbs-x2oJjV=A7Z65p9K-4-PzMxPRrPWngg@mail.gmail.com>
Date: Tue, 7 Feb 2017 16:49:52 -0800
From: Kees Cook <keescook@...omium.org>
To: David Windsor <dwindsor@...il.com>
Cc: "kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>, 
	Peter Zijlstra <peterz@...radead.org>, "Reshetova, Elena" <elena.reshetova@...el.com>, 
	Hans Liljestrand <ishkamiel@...il.com>
Subject: Re: [PATCH] refcount: add refcount_t API kernel-doc comments

On Tue, Feb 7, 2017 at 3:56 PM, David Windsor <dwindsor@...il.com> wrote:
> This adds kernel-doc comments for the new refcount_t API.  Additional feature documentation can go in
> Documentation/security, if needed.

Very cool. This may need to get rebased to Peter's lastest series
(which uses REFCOUNT_WARN rather than WARN).

Please add a "Signed-off-by:" line as well.

I think it'd also be valuable to have some documentation describing
how to actually use these, similar to your Examples section on the
wiki.

-Kees

-- 
Kees Cook
Pixel Security

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.