kernel-hardening - Re: [PATCH v2 11/11] MIPS: KASLR: Print relocation Information on boot

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160401084403.GA28123@linux-mips.org>
Date:   Fri, 1 Apr 2016 10:44:04 +0200
From:   Ralf Baechle <ralf@...ux-mips.org>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:     Matt Redfearn <matt.redfearn@...tec.com>,
        linux-mips@...ux-mips.org, kernel-hardening@...ts.openwall.com,
        Aaro Koskinen <aaro.koskinen@...ia.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Alexander Sverdlin <alexander.sverdlin@...il.com>,
        linux-kernel@...r.kernel.org, Jaedon Shin <jaedon.shin@...il.com>,
        Jonas Gorski <jogo@...nwrt.org>,
        Paul Burton <paul.burton@...tec.com>
Subject: Re: [PATCH v2 11/11] MIPS: KASLR: Print relocation Information on
 boot

On Thu, Mar 31, 2016 at 03:38:10PM +0300, Sergei Shtylyov wrote:

> >When debugging a relocated kernel, the addresses of the relocated
> >symbols and the offset applied is essential information. If the kernel
> >is compiled with debugging information, then print this information
> >during bootup using the same function as the panic notifer.
> 
>    Notifier.

Fixed when merging.

> >Signed-off-by: Matt Redfearn <matt.redfearn@...tec.com>
> >---
> >
> >Changes in v2: None
> >
> >  arch/mips/kernel/setup.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> >diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
> >index d8376d7b3345..ae71f8d9b555 100644
> >--- a/arch/mips/kernel/setup.c
> >+++ b/arch/mips/kernel/setup.c
> >@@ -477,9 +477,18 @@ static void __init bootmem_init(void)
> >  	 */
> >  	if (__pa_symbol(_text) > __pa_symbol(VMLINUX_LOAD_ADDRESS)) {
> >  		unsigned long offset;
> >+		extern void show_kernel_relocation(const char *level);
> >
> >  		offset = __pa_symbol(_text) - __pa_symbol(VMLINUX_LOAD_ADDRESS);
> >  		free_bootmem(__pa_symbol(VMLINUX_LOAD_ADDRESS), offset);
> >+
> >+#if (defined CONFIG_DEBUG_KERNEL) && (defined CONFIG_DEBUG_INFO)
> 
>    Not #if defined(CONFIG_DEBUG_KERNEL) && defined(CONFIG_DEBUG_INFO)?
> 
> [...]

CPP syntax is not what most people seem to believe that is the parenthesis
around the argument of defined are not required so above line is unusual
but perfectly ok.  However following boring standards is good so I changed
this, too.

  Ralf

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.