[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4D7AC8B0.3060102@bredband.net>
Date: Sat, 12 Mar 2011 02:13:20 +0100
From: magnum <rawsmooth@...dband.net>
To: john-dev@...ts.openwall.com
Subject: Re: New update to md5-gen, AND changes to the john core
'format' structures. (diff posted to Wiki)
On 03/11/2011 10:17 PM, jfoug wrote:
>> From: Solar Designer [mailto:solar@...nwall.com]
>> Basically, this moves the per-format hacks out of loader.c and takes
>> them into the formats themselves. I like this, but I didn't have a
>> chance to give this much thought yet, let alone review the specific
>> proposal/code.
>
> Hopefully you (and others) can easily critique.
I have no idea about the present code, but the general idea is excellent.
Fwiw I think I saw a misformatteded NT-format (using $NT$) hash file
result in segfault because there was : in user names (all of them, so in
practice there was a field between user and hash throughout the whole
file, and it was not an LM hash). Just a heads up, I haven't had time to
confirm or reproduce it.
I haven't seen any major problems merging my projects against this, I'm
all for it.
magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
