oss-security - [CVE-2022-23633] Possible exposure of information vulnerability in Action Pack

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CALBaBG95cw-_ZPCi+pppp_uhvX1ydSf=FP+sxfG-j4GDvieBFQ@mail.gmail.com>
Date: Fri, 11 Feb 2022 12:39:10 -0800
From: Aaron Patterson <aaron.patterson@...il.com>
To: oss-security@...ts.openwall.com, ruby-security-ann@...glegroups.com, 
	rubyonrails-security@...glegroups.com
Subject: [CVE-2022-23633] Possible exposure of information vulnerability in
 Action Pack

## Impact

Under certain circumstances response bodies will not be closed, for example
a bug in a webserver[1] or a bug in a Rack middleware. In the event a
response is not notified of a close, ActionDispatch::Executor will not know
to reset thread local state for the next request. This can lead to data
being leaked to subsequent requests, especially when interacting with
ActiveSupport::CurrentAttributes.

Upgrading to the FIXED versions of Rails will ensure mitigation if this
issue even in the context of a buggy webserver or middleware implementation.

## Patches

To aid users who aren't able to upgrade immediately we have provided
patches for
the two supported release series. They are in git-am format and consist of a
single changeset.

* 5.2-information-leak.patch
* 6.0-information-leak.patch
* 6.1-information-leak.patch
* 7.0-information-leak.patch

## Workarounds

Upgrading is highly recommended, but to work around this problem the
following middleware can be used:

```
class GuardedExecutor < ActionDispatch::Executor
  def call(env)
    ensure_completed!
    super
  end

  private

    def ensure_completed!
      @executor.new.complete! if @executor.active?
    end
end

# Ensure the guard is inserted before ActionDispatch::Executor
Rails.application.configure do
  config.middleware.swap ActionDispatch::Executor, GuardedExecutor, executor
end
```

## Credits

Thanks to Jean Boussier for fixing this!

1. https://github.com/puma/puma/pull/2812

Content of type "text/html" skipped

Download attachment "6.1-information-leak.patch" of type "application/octet-stream" (4161 bytes)

Download attachment "6.0-information-leak.patch" of type "application/octet-stream" (4161 bytes)

Download attachment "7.0-information-leak.patch" of type "application/octet-stream" (5474 bytes)

Download attachment "5.2-information-leak.patch" of type "application/octet-stream" (4158 bytes)

Please check out the Open Source Software Security Wiki, which is counterpart to this mailing list.

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.