|
|
Message-ID: <bd622b26-64b-31fb-9da-c1d8c5aafa4a@esi.com.au> Date: Fri, 28 Aug 2026 15:17:55 +1000 (AEST) From: Damian McGuckin <damianm@....com.au> To: musl@...ts.openwall.com Subject: Re: [PATCH] math: avoid four-way quadrant branch in atan2/atan2f On Fri, 28 Aug 2026, Alex A wrote: > Thanks, I left it out since it stays in the history, but i can make the > comment give the mapping if that reads better: > > /* m: bit 0 is sign(y), bit 1 is sign(x). m&2 clear gives +-z, > m&2 set gives +-(pi - (z - pi_lo)), sign from y. */ This is great and needs to be in there. But switch statement corresponds to how one would describe the quadrants mathematically so I would have the switch code in the comments as well. Thanks - Damian
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.