musl - Re: [PATCH] math: avoid four-way quadrant branch in atan2/atan2f

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACjHWf8ibxyNgu6KhXsvGNfJRKEfFUDC=uKyBP2Tbo46H95S7Q@mail.gmail.com>
Date: Fri, 28 Aug 2026 00:00:54 -0500
From: Alex A <splitterblue@...il.com>
To: Damian McGuckin <damianm@....com.au>
Cc: musl@...ts.openwall.com
Subject: Re: [PATCH] math: avoid four-way quadrant branch in atan2/atan2f

Thanks, I left it out since it stays in the history, but i can make the
comment give the mapping if that reads better:

/* m: bit 0 is sign(y), bit 1 is sign(x).  m&2 clear gives +-z,
   m&2 set gives +-(pi - (z - pi_lo)), sign from y. */


On Thu, Aug 27, 2026 at 11:55 PM Damian McGuckin <damianm@....com.au> wrote:

>
> I would leave the switch and its related code that is being replaced as a
> comment.
>
> My 2c - Damian
>

Content of type "text/html" skipped

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.