[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20260416131352.GD1827@brightrain.aerifal.cx>
Date: Thu, 16 Apr 2026 09:13:52 -0400
From: Rich Felker <dalias@...c.org>
To: Alex Rønne Petersen <alex@...xrp.com>
Cc: musl@...ts.openwall.com
Subject: Re: [PATCH] mipsn32: pass syscall arguments as long long
instead of long
On Thu, Apr 16, 2026 at 04:10:17AM +0200, Alex Rønne Petersen wrote:
> This matches what is done for the x32 port. As far as I can tell based on kernel
> and glibc sources, this is the expected kABI for mipsn32. Before this patch, you
> would get compiler warnings about truncation of off_t values in various syscall
> wrappers.
This patch doesn't actually do what the description says. The
arguments passed in to the __syscallN inlines are long long, but the
register locals passed into the inline asm are still long.
I'm skeptical that the intendedchange is correct to begin with tho. As
I understand it, x32 actually has the kernel receive 64-bit registers
and might even use 64-bit values in a few places, but mips n32 always
treats the syscall args as 32-bit.
If off_t is being truncated somewhere, this is probably actually a
bug, and the patch is just burying it, not fixing it. Can you report
that so it can be investigated?
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
