Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20260416021017.1435898-1-alex@alexrp.com>
Date: Thu, 16 Apr 2026 04:10:17 +0200
From: Alex Rønne Petersen <alex@...xrp.com>
To: musl@...ts.openwall.com
Cc: Alex Rønne Petersen <alex@...xrp.com>
Subject: [PATCH] mipsn32: pass syscall arguments as long long instead of long

This matches what is done for the x32 port. As far as I can tell based on kernel
and glibc sources, this is the expected kABI for mipsn32. Before this patch, you
would get compiler warnings about truncation of off_t values in various syscall
wrappers.

This change has been tested by running Zig's module tests for
mips64-linux-muslabin32 and mips64el-linux-muslabin32 with no regressions.
---
 arch/mipsn32/syscall_arch.h | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/arch/mipsn32/syscall_arch.h b/arch/mipsn32/syscall_arch.h
index c681905d..0847c3cc 100644
--- a/arch/mipsn32/syscall_arch.h
+++ b/arch/mipsn32/syscall_arch.h
@@ -1,6 +1,9 @@
 #define __SYSCALL_LL_E(x) (x)
 #define __SYSCALL_LL_O(x) (x)
 
+#define __scc(X) sizeof(1?(X):0ULL) < 8 ? (unsigned long) (X) : (long long) (X)
+typedef long long syscall_arg_t;
+
 #define SYSCALL_RLIM_INFINITY (-1UL/2)
 
 #if __mips_isa_rev >= 6
@@ -13,7 +16,7 @@
 	"$14", "$15", "$24", "$25", "hi", "lo", "memory"
 #endif
 
-static inline long __syscall0(long n)
+static inline long __syscall0(long long n)
 {
 	register long r7 __asm__("$7");
 	register long r2 __asm__("$2");
@@ -25,7 +28,7 @@ static inline long __syscall0(long n)
 	return r7 && r2>0 ? -r2 : r2;
 }
 
-static inline long __syscall1(long n, long a)
+static inline long __syscall1(long long n, long long a)
 {
 	register long r4 __asm__("$4") = a;
 	register long r7 __asm__("$7");
@@ -38,7 +41,7 @@ static inline long __syscall1(long n, long a)
 	return r7 && r2>0 ? -r2 : r2;
 }
 
-static inline long __syscall2(long n, long a, long b)
+static inline long __syscall2(long long n, long long a, long long b)
 {
 	register long r4 __asm__("$4") = a;
 	register long r5 __asm__("$5") = b;
@@ -53,7 +56,7 @@ static inline long __syscall2(long n, long a, long b)
 	return r7 && r2>0 ? -r2 : r2;
 }
 
-static inline long __syscall3(long n, long a, long b, long c)
+static inline long __syscall3(long long n, long long a, long long b, long long c)
 {
 	register long r4 __asm__("$4") = a;
 	register long r5 __asm__("$5") = b;
@@ -69,7 +72,7 @@ static inline long __syscall3(long n, long a, long b, long c)
 	return r7 && r2>0 ? -r2 : r2;
 }
 
-static inline long __syscall4(long n, long a, long b, long c, long d)
+static inline long __syscall4(long long n, long long a, long long b, long long c, long long d)
 {
 	register long r4 __asm__("$4") = a;
 	register long r5 __asm__("$5") = b;
@@ -85,7 +88,7 @@ static inline long __syscall4(long n, long a, long b, long c, long d)
 	return r7 && r2>0 ? -r2 : r2;
 }
 
-static inline long __syscall5(long n, long a, long b, long c, long d, long e)
+static inline long __syscall5(long long n, long long a, long long b, long long c, long long d, long long e)
 {
 	register long r4 __asm__("$4") = a;
 	register long r5 __asm__("$5") = b;
@@ -102,7 +105,7 @@ static inline long __syscall5(long n, long a, long b, long c, long d, long e)
 	return r7 && r2>0 ? -r2 : r2;
 }
 
-static inline long __syscall6(long n, long a, long b, long c, long d, long e, long f)
+static inline long __syscall6(long long n, long long a, long long b, long long c, long long d, long long e, long long f)
 {
 	register long r4 __asm__("$4") = a;
 	register long r5 __asm__("$5") = b;
-- 
2.51.0

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.