Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZxuDY6etBC6t_Y9U@probook>
Date: Fri, 25 Oct 2024 13:39:15 +0200
From: J. Neuschäfer <j.neuschaefer@....net>
To: musl@...ts.openwall.com
Cc: J. Neuschäfer <j.neuschaefer@....net>
Subject: Re: [PATCH MCM 0/3] musl-cross-make: add newer GCC versions

On Thu, Oct 24, 2024 at 09:36:20AM -0400, Rich Felker wrote:
> On Thu, Oct 24, 2024 at 09:11:42AM -0400, Rich Felker wrote:
[...]
> > Weird, I'm still getting problems. git-am gives me:
> >
> > ..git/rebase-apply/patch:40: space before tab in indent.
> >                        "|fstack-protector-strong|fstack-protector-explicit" \
> > ..git/rebase-apply/patch:88: space before tab in indent.
> >         extra_headers="s390intrin.h htmintrin.h htmxlintrin.h vecintrin.h"
> > ..git/rebase-apply/patch:89: space before tab in indent.
> >         ;;
> > ..git/rebase-apply/patch:93: space before tab in indent.
> >         cpu_type=sh
> > ..git/rebase-apply/patch:94: space before tab in indent.
> >         extra_options="${extra_options} fused-madd.opt"
> > warning: squelched 79 whitespace errors
> > warning: 84 lines add whitespace errors.

These are normal, AFAICT, and I also get them with the original patches,
which apply fine.

> > and the applied patches have context lines that should be an empty
> > line with the one-space diff prefix replaced to empty lines (no
> > leading diff space).

Ah, that's quite unfortunate

> >
> > Can you verify whether this is expected or if something is getting
> > munged in the mail?

I can confirm that this happens after the email round-trip, but not
before.

> It looks like your mailer munged them sending the attachments as
> message/rfc822 mime, which is lossy with respect to whitespace, rather
> than text/plain or something that would be safely preserved. The
> "trailing whitespace" on the context lines is missing in the actual
> message I received.

I'm sending them in a tarball now, in the hope that no mail software
looks inside.  Alternatively, you may:

git pull https://codeberg.org/neuschaefer/musl-cross-make bump


Best regards,
 jn

Download attachment "patches.tgz" of type "application/x-gtar-compressed" (16390 bytes)

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.