Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241024133619.GX10433@brightrain.aerifal.cx>
Date: Thu, 24 Oct 2024 09:36:20 -0400
From: Rich Felker <dalias@...c.org>
To: J. Neuschäfer <j.neuschaefer@....net>
Cc: musl@...ts.openwall.com
Subject: Re: [PATCH MCM 0/3] musl-cross-make: add newer GCC versions

On Thu, Oct 24, 2024 at 09:11:42AM -0400, Rich Felker wrote:
> On Wed, Oct 23, 2024 at 02:29:13PM +0200, J. Neuschäfer wrote:
> > On Tue, Oct 22, 2024 at 05:52:22PM -0400, Rich Felker wrote:
> > > On Wed, Oct 02, 2024 at 05:40:03PM +0200, J. Neuschäfer wrote:
> > > > This patchset adds newer GCC versions to MCM. Patches are copied from
> > > > GCC 11 and only very lightly modifed (which can be verified by diffing
> > > > the patch directories).
> > > >
> > > > I haven't tested the resulting toolchains, so there might be some bugs
> > > > lurking.
> > >
> > > Could you resend these as attachments instead of lkml-thread-style?
> > > Something got messed up with the whitespace and git am is applying
> > > them but giving results that have gratuitous whitespace diffs, and I'd
> > > rather not track down whether any of that is breaking.
> > >
> > > Rich
> > 
> > Here they are.
> 
> Weird, I'm still getting problems. git-am gives me:
> 
> ..git/rebase-apply/patch:40: space before tab in indent.
>                        "|fstack-protector-strong|fstack-protector-explicit" \
> ..git/rebase-apply/patch:88: space before tab in indent.
>         extra_headers="s390intrin.h htmintrin.h htmxlintrin.h vecintrin.h"
> ..git/rebase-apply/patch:89: space before tab in indent.
>         ;;
> ..git/rebase-apply/patch:93: space before tab in indent.
>         cpu_type=sh
> ..git/rebase-apply/patch:94: space before tab in indent.
>         extra_options="${extra_options} fused-madd.opt"
> warning: squelched 79 whitespace errors
> warning: 84 lines add whitespace errors.
> 
> and the applied patches have context lines that should be an empty
> line with the one-space diff prefix replaced to empty lines (no
> leading diff space).
> 
> Can you verify whether this is expected or if something is getting
> munged in the mail?

It looks like your mailer munged them sending the attachments as
message/rfc822 mime, which is lossy with respect to whitespace, rather
than text/plain or something that would be safely preserved. The
"trailing whitespace" on the context lines is missing in the actual
message I received.

Rich

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.