|
|
Message-ID: <20240612165430.GK3766212@port70.net>
Date: Wed, 12 Jun 2024 18:54:30 +0200
From: Szabolcs Nagy <nsz@...t70.net>
To: musl@...ts.openwall.com
Cc: Meng Zhuo <mzh@....io>
Subject: Re: [PATCH v3] math: add riscv64 round/roundf
* Szabolcs Nagy <nsz@...t70.net> [2024-06-12 18:50:04 +0200]:
> > +double round(double x)
> > +{
> > + if (!isfinite(x)) return x;
>
> !isfinite(x) && fabs(x) >= 0x1p52
i meant ||, not &&
>
> otherwise n can overflow below.
>
> (note that the check can be a single cmp+branch on the bit representation of x)
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.