[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240125191025.GK4163@brightrain.aerifal.cx>
Date: Thu, 25 Jan 2024 14:10:25 -0500
From: Rich Felker <dalias@...c.org>
To: "Ignotas \"gns\" WANG" <infiwang@...ton.me>
Cc: "musl@...ts.openwall.com" <musl@...ts.openwall.com>
Subject: Re: [PATCH] riscv: correct symbol version of
__vdso_flush_icache
On Thu, Jan 25, 2024 at 02:05:34PM -0500, Rich Felker wrote:
> On Thu, Jan 25, 2024 at 04:55:16PM +0000, Ignotas "gns" WANG wrote:
> > Hi,
> >
> > I'm porting LuaJIT to RISC-V, our binary built with musl would
> > occasionally SIGILL at patched JIT insns. It looks that musl's
> > __riscv_flush_icache is faulty, which may be the cause of this cache
> > coherency issue.
> >
> > For the patch, see the attachments.
> >
> > Since I'm not a subscriber to the musl list, CC me please.
>
> Just to be clear, this was always wrong, not a change on the kernel
> side where either symbol version might be seen depending on kernel
> version, right?
OK, answering my own question. The original Linux commit introducing
riscv vdso, e2c0cdfba7f69925afc92b20cd9835d81e11a4f1, has:
+VERSION
+{
+ LINUX_4.15 {
and 921ebd8f2c081b3cf6c3b29ef4103eef3ff26054 adds
__riscv_flush_icache under that. So apparently the version was just
miscopied/typo when added to musl.
I'll apply this right away and it'll be in the upcoming release.
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
