|
Message-ID: <20230205200003.GA1998@voyager> Date: Sun, 5 Feb 2023 21:00:03 +0100 From: Markus Wichmann <nullplan@....net> To: musl@...ts.openwall.com Cc: Peter Collingbourne <pcc@...gle.com> Subject: Re: [PATCH] arm: Use __WCHAR_TYPE__ for wchar_t if defined On Sat, Feb 04, 2023 at 08:08:36AM +0100, alice wrote: > On Sat Feb 4, 2023 at 7:30 AM CET, Peter Collingbourne wrote: > > When building with -fshort-wchar the definition of wchar_t is > > incorrect. Get the correct definition from the compiler if available. > > > > This is useful when reusing the freestanding parts of musl on a > > bare-metal target that uses -fshort-wchar. > > somebody talked about this in 2015, see > https://www.openwall.com/lists/musl/2015/02/18/2 > for the previous discussion. > > i understand in this case it's proposed a little different- > "reusing freestanding parts" as opposed to building a whole libc.so, but in > that case you could most likely patch this in when reusing it standalone only? > > it doesn't seem a good idea for it to be there, in general. Seconded. A lot of code in musl depends on wchar_t being able to hold the current maximum Unicode codepoint of 0x10FFFF at least, so the type must be at least 21 bits. Ciao, Markus
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.