[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220413140656.GU7074@brightrain.aerifal.cx>
Date: Wed, 13 Apr 2022 10:06:57 -0400
From: Rich Felker <dalias@...c.org>
To: Christian Brauner <brauner@...nel.org>
Cc: Arnd Bergmann <arnd@...nel.org>, musl@...ts.openwall.com
Subject: Re: Re: add loongarch64 port
On Wed, Apr 13, 2022 at 09:19:11AM +0200, Christian Brauner wrote:
> On Sat, Apr 09, 2022 at 09:19:39AM -0400, Rich Felker wrote:
> > On Sat, Apr 09, 2022 at 01:06:13PM +0200, Arnd Bergmann wrote:
> > > On Sat, Apr 9, 2022 at 5:55 AM 王洪亮 <wanghongliang@...ngson.cn> wrote:
> > > > 在 2022/4/8 下午2:46, Arnd Bergmann 写道:
> > > > > On Fri, Apr 8, 2022 at 4:21 AM 王洪亮 <wanghongliang@...ngson.cn> wrote:
> > > > >
> > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fa729c4df5589
> > > > >
> > > > > What happens in the clone() syscall in the kernel is that the size
> > > > > gets added to the initial pointer on normal architectures (parisc and ia64
> > > > > being the exceptions). If you already have the stack pointer, I think you can
> > > > > just pass size=0 as we do internally in the kernel.
> > > > >
> > > > > If there was a port of musl to one of the architectures that does it
> > > > > differently,
> > > > > then changing callers such as
> > > > >
> > > > > pid = __clone(child, stack+sizeof stack,
> > > > > CLONE_VM|CLONE_VFORK|SIGCHLD, &args);
> > > > >
> > > > > would be required, and the separate size argument in clone3() could
> > > > > help keep that hidden from musl.
> > > > >
> > > > > Arnd
> > > >
> > > >
> > > > In LoongArch,the stack is grows down.
> > > >
> > > > As previous suggested,I implement __NR_clone3 syscall within __clone()
> > > > in loongarch port,based on __clone() interface unchanged and the
> > > > architecture-independent code of call __clone() unchanged.
> > > >
> > > > In __NR_clone3 syscall,I need pass the lowest address of memory area to
> > > > clone_args.stack,and pass stack_size to clone_args.stack_size(stack_size
> > > > must not be 0)
> > > > if (kargs->stack_size == 0)
> > > > return false;
> > > >
> > > > current,the __clone()'s input parameters have no "stack_size",so I can't
> > > > pass valid(must be size!=0) stack_size to clone3.
> > > >
> > > > your meaning is pass stack_size=0 when the input parameter "stack" of
> > > > __clone()
> > > > is already stack point? but pass stack_size=0 is illegal.
> > >
> > > Ah, you are right, that doesn't work at the moment. You dropped Christian
> > > from the Cc list, adding him back because he probably has an idea
> > > for how to address that.
> > >
> > > It looks like it could be fixed for the internal callers of __clone() by
> > > adding a __clone3() call that takes the size argument, and falls back
> > > to calling __clone() on architectures that have that. I don't see how
> > > one would do it for the generic clone() library function call though.
> >
> > size=4k and passing stack-4k? O_o
> >
> > This seems like a ridiculous kernel regression to require a size when
> > none may be available...
>
> Hm, clone3() is a separate system call. The aim had never been to
> provide 1:1 compatibility with legacy clone(). So I fail to see how this
> is a regression.
It's only a regression if __NR_clone3 is expected to provide a
replacement for __NR_clone where new archs will drop __NR_clone. If
both syscalls will continue to exist then I agree it's not a
regression.
> (I'd appreciate if we could stay away from unnecessary qualifiers like
> "ridiculous". That doesn't really help the thread in any way.)
Fair.
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
