Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b01158d0-2820-eb85-5154-cb7de961e101@loongson.cn>
Date: Thu, 24 Mar 2022 09:35:25 +0800
From: 王洪亮 <wanghongliang@...ngson.cn>
To: musl@...ts.openwall.com
Subject: Re: add loongarch64 port

Hi,

     yes, this is a wrong. I fixed this error.

diff --git a/arch/loongarch64/bits/signal.h b/arch/loongarch64/bits/signal.h
index a28ec91a..e6613516 100644
--- a/arch/loongarch64/bits/signal.h
+++ b/arch/loongarch64/bits/signal.h
@@ -76,4 +76,4 @@ typedef struct __ucontext
  #define SIGSYS          31
  #define SIGUNUSED       SIGSYS

-#define _NSIG 64
+#define _NSIG 65
-- 

Hongliang Wang


在 2022/3/23 上午3:03, Rich Felker 写道:
> On Tue, Mar 22, 2022 at 11:52:35AM +0800, 王洪亮 wrote:
>> diff --git a/arch/loongarch64/bits/signal.h b/arch/loongarch64/bits/signal.h
>> new file mode 100644
>> index 00000000..a28ec91a
>> --- /dev/null
>> +++ b/arch/loongarch64/bits/signal.h
>> @@ -0,0 +1,79 @@
>> [...]
>> +#define _NSIG 64
> It was also pointed out to me that this is likely wrong. _NSIG needs
> to be 1 plus the last signal number, so 65 if there are 64 signals
> like most archs have. Or, if you kept the mips weirdness, 128 (since
> mips has 127 signals).
>
> Rich

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.