[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAK8P3a14Ju1mJMpzpdPGR70emwcOJ3njCbm1Xzj+4iaTcacuoA@mail.gmail.com>
Date: Tue, 22 Mar 2022 21:36:30 +0100
From: Arnd Bergmann <arnd@...nel.org>
To: musl@...ts.openwall.com
Subject: Re: add loongarch64 port
On Tue, Mar 22, 2022 at 8:03 PM Rich Felker <dalias@...c.org> wrote:
>
> On Tue, Mar 22, 2022 at 11:52:35AM +0800, 王洪亮 wrote:
> > diff --git a/arch/loongarch64/bits/signal.h b/arch/loongarch64/bits/signal.h
> > new file mode 100644
> > index 00000000..a28ec91a
> > --- /dev/null
> > +++ b/arch/loongarch64/bits/signal.h
> > @@ -0,0 +1,79 @@
> > [...]
> > +#define _NSIG 64
>
> It was also pointed out to me that this is likely wrong. _NSIG needs
> to be 1 plus the last signal number, so 65 if there are 64 signals
> like most archs have. Or, if you kept the mips weirdness, 128 (since
> mips has 127 signals).
The kernel port originally used the mips signal handling conventions,
but I pointed out during the review that this is not a good choice for
a new architecture.
The version that is currently under review for the kernel uses the
asm-generic version of all the ABI structures, with the normal 64
signals.
Arnd
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
