Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200812221311.GF879655@port70.net>
Date: Thu, 13 Aug 2020 00:13:11 +0200
From: Szabolcs Nagy <nsz@...t70.net>
To: Alexander Monakov <amonakov@...ras.ru>, musl@...ts.openwall.com
Subject: Re: [PATCH 1/3] setjmp: fix x86-64 longjmp argument adjustment

* Szabolcs Nagy <nsz@...t70.net> [2020-08-12 23:44:05 +0200]:
> diff --git a/src/setjmp/aarch64/longjmp.s b/src/setjmp/aarch64/longjmp.s
> index 7c4655fa..b22042a2 100644
> --- a/src/setjmp/aarch64/longjmp.s
> +++ b/src/setjmp/aarch64/longjmp.s
> @@ -18,7 +18,6 @@ longjmp:
>  	ldp d12, d13, [x0,#144]
>  	ldp d14, d15, [x0,#160]
>  
> -	mov x0, x1
> -	cbnz x1, 1f
> -	mov x0, #1
> +	cmp w1, 0
> +	csinc w0, w1, wzr, ne
>  1:	br x30

v2 because the 1: label is no longer used


View attachment "0001-aarch64-fix-setjmp-return-value.patch" of type "text/x-diff" (837 bytes)

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.