Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200521192102.GF1079@brightrain.aerifal.cx>
Date: Thu, 21 May 2020 15:21:03 -0400
From: Rich Felker <dalias@...c.org>
To: enh <enh@...gle.com>
Cc: musl@...ts.openwall.com
Subject: Re: remove SIGSTKFLT on mips?

On Thu, May 21, 2020 at 09:51:29AM -0700, enh wrote:
> (context: https://github.com/landley/toybox/issues/194)
> 
> seems like musl defines SIGSTKFLT for mips as signal 7. the kernel
> disagrees and says SIGEMT is 7, and that mips doesn't have a
> SIGSTKFLT:
> 
> arch/mips/include/uapi/asm/signal.h:#define SIGEMT 7
> 
> git blame says SIGSTKFLT was introduced in the original commit:
> 
> commit 6315004f6102dca44c4ba50654a36967b8b9c2a6
> Author: Rich Felker <dalias@...ifal.cx>
> Date:   Wed Jul 11 04:22:13 2012 -0400
> 
>     initial version of mips (o32) port, based on work by Richard
> Pennington (rdp)
> 
>     basically, this version of the code was obtained by starting with
>     rdp's work from his ellcc source tree, adapting it to musl's build
>     system and coding style, auditing the bits headers for discrepencies
>     with kernel definitions or glibc/LSB ABI or large file issues, fixing
>     up incompatibility with the old binutils from aboriginal linux, and
>     adding some new special cases to deal with the oddities of sigaction
>     and pipe syscall interfaces on mips.
> 
>     at present, minimal test programs work, but some interfaces are broken
>     or missing. threaded programs probably will not link.

I have the two attached patches pending push if there's no objection.

Rich

View attachment "0001-handle-possibility-that-SIGEMT-replaces-SIGSTKFLT-in.patch" of type "text/plain" (1109 bytes)

View attachment "0002-fix-incorrect-SIGSTKFLT-on-all-mips-archs.patch" of type "text/plain" (1703 bytes)

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.