Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190913180648.GH9017@brightrain.aerifal.cx>
Date: Fri, 13 Sep 2019 14:06:48 -0400
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] Allow %lf in wprintf

On Wed, Sep 11, 2019 at 11:09:03PM -0700, Brion Vibber wrote:
> On the emscripten mailing list we got a report that using %lf as a format
> specifier for doubles worked in printf but not wprintf, which I was able to
> confirm looking at the musl implementation we're using.
> 
> It looks like support for %lf in printf was added in 2012 in
> commit cc3a44666, but didn't get copied to the wprintf implementation so
> they're just out of sync. I've attached a small patch which copies the same
> fix to the wprintf side.

Thanks! Applying.

> Please let me know if there's any test cases I should add to, or anything
> else. Thanks!

Coverage for wide printf in libc-test is probably poor. Please feel
free (but not obligated) to submit either a regression test for this
specific bug or some general functionality tests covering this case
and others. You can submit libc-test patches on the musl list too.

Rich

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.