[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190806175006.GZ9017@brightrain.aerifal.cx>
Date: Tue, 6 Aug 2019 13:50:06 -0400
From: Rich Felker <dalias@...ifal.cx>
To: musl@...ts.openwall.com
Subject: Re: [PATCH v2] remove riscv64 user_regs_struct
On Tue, Aug 06, 2019 at 08:47:29PM +0300, Baruch Siach wrote:
> user_regs_struct removal fixes possible conflict with the kernel
> definition of the same struct in asm/ptrace.h. glibc does not define
> user_regs_struct for riscv either.
> ---
> v2: Remove user_regs_struct entirely following feedback from Rich and
> Szabolcs
> ---
> arch/riscv64/bits/user.h | 35 -----------------------------------
> 1 file changed, 35 deletions(-)
>
> diff --git a/arch/riscv64/bits/user.h b/arch/riscv64/bits/user.h
> index bd0f0fc7027f..d2e383b24e53 100644
> --- a/arch/riscv64/bits/user.h
> +++ b/arch/riscv64/bits/user.h
> @@ -1,38 +1,3 @@
> -struct user_regs_struct {
> - unsigned long pc;
> - unsigned long ra;
> - unsigned long sp;
> - unsigned long gp;
> - unsigned long tp;
> - unsigned long t0;
> - unsigned long t1;
> - unsigned long t2;
> - unsigned long s0;
> - unsigned long s1;
> - unsigned long a0;
> - unsigned long a1;
> - unsigned long a2;
> - unsigned long a3;
> - unsigned long a4;
> - unsigned long a5;
> - unsigned long a6;
> - unsigned long a7;
> - unsigned long s2;
> - unsigned long s3;
> - unsigned long s4;
> - unsigned long s5;
> - unsigned long s6;
> - unsigned long s7;
> - unsigned long s8;
> - unsigned long s9;
> - unsigned long s10;
> - unsigned long s11;
> - unsigned long t3;
> - unsigned long t4;
> - unsigned long t5;
> - unsigned long t6;
> -};
> -
> struct user_fpregs_struct {
> double f[32];
> unsigned int fcsr;
> --
> 2.20.1
It's not just that struct but the whole file. I've got the removal
already committed here though, pending push with a queue of stuff from
the list. Thanks.
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
