|
Message-ID: <CAJ86T=V979AvMkPum80zA8RTWwHgePei8zocrFhCg8VWKNhr6A@mail.gmail.com> Date: Fri, 28 Jun 2019 15:55:56 -0700 From: Andre McCurdy <armccurdy@...il.com> To: musl@...ts.openwall.com Subject: Re: [PATCH] fix build failure on arm because of missing clz instruction On Fri, Aug 24, 2018 at 4:20 PM Rich Felker <dalias@...c.org> wrote: > On Fri, Aug 24, 2018 at 02:58:04PM -0700, Andre McCurdy wrote: > > On Fri, Aug 24, 2018 at 12:30 PM, Szabolcs Nagy <nsz@...t70.net> wrote: > > > another arm patch, clz usage (in fma) was broken with -mthumb -march=armv5t. > > > > That conditional was originally written under the assumption that musl > > doesn't support thumb1 (so -mthumb -march=armv5t is not a supported > > configuration). > > > > Was that assumption wrong? > > musl does not support being pure-thumb1 code, because some of the asm > source files are not thumb-compatible, but I think the C code can be > compiled as thumb1. -mthumb is only passed to the assembler for asm > source files if __thumb2__ is defined. Sorry to resurrect such an old thread, but it seems this patch was never applied? Without it, -mthumb -march=armv5t still fails to build due to clz getting into C code via inline assembler.
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.