[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190607055051.GQ1506@brightrain.aerifal.cx>
Date: Fri, 7 Jun 2019 01:50:51 -0400
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: [PATCH 2/2] define mt_fileno and mt_fileno struct mtget
members as mt_blkno
On Fri, Jun 07, 2019 at 07:42:15AM +0200, Petr Vorel wrote:
> Hi Rich,
>
> ....
> > > +++ b/include/sys/mtio.h
> > > @@ -54,8 +54,8 @@ struct mtget {
> > > long mt_dsreg;
> > > long mt_gstat;
> > > long mt_erreg;
> > > - int mt_fileno;
> > > - int mt_blkno;
> > > + daddr_t mt_fileno;
> > > + daddr_t mt_blkno;
> ....
>
> > Can you explain what problem this is supposed to fix? It definitely
> > needs further discussion to determine what the right way is, but
> > that's impossible without knowing the problem you're trying to solve.
> Thanks for review. Not a problem for me actually. I've noticed, that glibc (and
> thus uclibc-ng) and bionic follow kernel sources, which defines it long for mips
> (and for sparc, but musl doesn't support it). Default is int [2]. Drop this
> patch if this is not an issue.
Well it might be a problem on some archs. I think it's worth looking
into. We might need to add bits/mtio.h to define it appropriately for
the arch.
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
