Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190607053102.GP1506@brightrain.aerifal.cx>
Date: Fri, 7 Jun 2019 01:31:02 -0400
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: [PATCH 2/2] define mt_fileno and mt_fileno struct mtget
 members as mt_blkno

On Fri, Jun 07, 2019 at 07:14:44AM +0200, Petr Vorel wrote:
> following kernel definition, this fixes size on mips.
> 
> Signed-off-by: Petr Vorel <petr.vorel@...il.com>
> ---
>  include/sys/mtio.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/sys/mtio.h b/include/sys/mtio.h
> index f16a529b..4dd4c548 100644
> --- a/include/sys/mtio.h
> +++ b/include/sys/mtio.h
> @@ -54,8 +54,8 @@ struct mtget {
>  	long mt_dsreg;
>  	long mt_gstat;
>  	long mt_erreg;
> -	int mt_fileno;
> -	int mt_blkno;
> +	daddr_t mt_fileno;
> +	daddr_t mt_blkno;
>  };
>  
>  #define MT_ISUNKNOWN		0x01
> -- 
> 2.21.0

Can you explain what problem this is supposed to fix? It definitely
needs further discussion to determine what the right way is, but
that's impossible without knowing the problem you're trying to solve.

Rich

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.