[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190302173609.GJ23599@brightrain.aerifal.cx>
Date: Sat, 2 Mar 2019 12:36:09 -0500
From: Rich Felker <dalias@...c.org>
To: Sebastian Kemper <sebastian_ml@....net>
Cc: musl@...ts.openwall.com
Subject: Re: Asterisk 16 segmentation fault
On Sat, Mar 02, 2019 at 06:16:42PM +0100, Sebastian Kemper wrote:
> On Thu, Feb 28, 2019 at 10:19:02PM +0100, Szabolcs Nagy wrote:
> > e.g. the segfault can be avoided by
> >
> > - const char *dlerror_msg = ast_strdupa(dlerror());
> > + const char *dlerror_msg = dlerror(); dlerror_msg = ast_strdupa(dlerror_msg ? dlerror_msg : "");
> >
> > but we would need to know what this code is trying to do
> > (and how it worked before) for a proper fix.
>
> Hello Szabolcs,
>
> This seems to work. I was able to compile and run asterisk with this
> (and make some phone calls).
>
> I will raise a bug report upstream for this and point them here. I'm not
> going to raise a pull request with your patch as upstream's handling of
> pull requests includes signing some agreement etc.
>
> I'll just point them to this thread and see what comes out of it.
>
> Thanks again!
Please be aware: This is just fixing the crash, but isn't fixing the
logic error in the Asterisk software that led to it. I'm pretty sure
module loading is not working correctly. Actually fixing this is going
to be a much bigger task.
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
