[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20181110172325.GD21289@port70.net>
Date: Sat, 10 Nov 2018 18:23:26 +0100
From: Szabolcs Nagy <nsz@...t70.net>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] Fix many compiler warnings
* Sedrubal <dev@...rubal.de> [2018-11-10 17:48:23 +0100]:
> I'm building musl for aarch64 with clang and get many compiler warnings
> (mostly Wbitwise-op-parentheses, Wshift-op-parentheses and Wlogical-op-parentheses).
> I tried to fix them (and I hope, I did not introduce new bugs).
suppress the warnings, you will just introduce bugs
> - return __x>>24 | __x>>8&0xff00 | __x<<8&0xff0000 | __x<<24;
> + return __x>>24 | __x>>(8&0xff00) | __x<<(8&0xff0000) | __x<<24;
e.g. this is wrong
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
