[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1320d9deaa1f9e6808a3aa795cb5adcb@mail.tecnico.ulisboa.pt>
Date: Tue, 17 Jan 2017 15:49:03 +0000
From: Bernardo Pascoal Figueiredo
<bernardopascoalfigueiredo@...nico.ulisboa.pt>
To: musl@...ts.openwall.com
Subject: Re: Implementation of GLOB_TILDE
Forgot the patch file.
On 2017-01-17 15:44, Bernardo Pascoal Figueiredo wrote:
> Hi,
>
> I'm sending as attachment a a patch that implments the GLOB_TILDE
> extension to
> the glob function.
>
> This functions is helpful to compile some software that otherwise would
> not
> compile(without patching) with musl like i3wm.
>
> I tested the code(test file as attachment) and the results seem to be
> correct.
>
> I have a few questions though:
> * How do I contribute to musl? Should I just send patches to this
> mailing list
> or should I make pull requests?
>
> * I defined GLOB_TILDE as 0x100, but I think this won't work on
> architectures
> that have sizeof(int) == 2, as the flags argument in glob is an int.
>
> * I think it's best to define GLOB_TILDE in glob.h inside a '#if
> defined(_GNU_SOURCE) || defined(_BSD_SOURCE)' what do you think?
>
> * I had to copy strlcat and strlcpy to glob.c so I could use them. I
> had to do
> this because musl isn't compile as _GNU_SOURCE or _BSD_SOURCE so
> string.h
> doesn't expose these functions. How should I fix this?
>
> Thanks,
> Bernardo Figueiredo
View attachment "glob_tilde.patch" of type "text/x-diff" (4516 bytes)
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
