[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CABBv4Tb9av4D=E5g80pL+FyniCdc==Fr4PsEftbj65UG+6dQZQ@mail.gmail.com>
Date: Tue, 17 Nov 2015 06:05:21 +0000
From: Petr Hosek <phosek@...omium.org>
To: musl@...ts.openwall.com
Subject: Re: Support for out-of-tree build
One minor improvement, we obviously don't need more than one .mk file per
directory.
On Mon, Nov 16, 2015 at 6:45 PM Petr Hosek <phosek@...omium.org> wrote:
> This is the final solution I've converged to. It's a bigger change than
> the previous version, but the implementation is actually cleaner. In
> nutshell, I've replaced all .sub files with .mk equivalent files which are
> included from the Makefile. I'm then filtering out all C object files which
> have assembly equivalent. This allowed me to simplify the build rules while
> we still support both in-tree and out-of-tree builds. Please let me know
> what you think, I'll be happy to iterate on this.
>
> On Thu, Nov 12, 2015 at 3:41 PM Rich Felker <dalias@...c.org> wrote:
>
>> On Thu, Nov 12, 2015 at 10:35:07PM +0000, Petr Hosek wrote:
>> > >
>> > > What if we put the *.o files for arch asm in the arch dirs rather than
>> > > in the main src dirs. Is there some clean way we could write a rule to
>> > > remove the base .o files from OBJS when the arch-specific .o files are
>> > > there?
>> >
>> > That's what I had in mind and I've already implemented it, but I
>> couldn't
>> > get the *.sub files to work in that setup. However, if we replace them
>> with
>> > Makefile fragments as you suggested it might it might solve that
>> problem.
>> > Let me try that out and I'll let you know whether this is a way to go.
>>
>> I don't see why the same wouldn't work for .sub files: their .o files
>> could be put in their own dirs. But I'd rather get rid of them still
>> and just have the arch provide an ordered list, for the specific
>> subarch, of arch and subarch .s or .c files that should replace the .c
>> files "above" them in the tree. Do you have good ideas for how to do
>> this?
>>
>> Rich
>>
>
Content of type "text/html" skipped
View attachment "suport-out-of-tree-build.patch" of type "text/x-patch" (23862 bytes)
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
