Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150616192504.GF3247@euler>
Date: Tue, 16 Jun 2015 21:25:04 +0200
From: Felix Janda <felix.janda@...teo.de>
To: netfilter-devel@...r.kernel.org
Cc: musl@...ts.openwall.com
Subject: [PATCH iptables RFC 4/4] libxt_TCPOPTSTRIP: Use local copy of
 TCPOPTS constants

musl does not provide these constants in <netinet/tcp.h>

Signed-off-by: Felix Janda <felix.janda@...teo.de>
---
It is not clear to me whether these constants belong to iptables or musl's
netinet/tcp.h. So this message is CC'd to the musl list.

In the code indexed by debian code search I have only found iptables and
traceroute using them without having a local copy of tcp.h.

Note that this patch is incomplete: utils/nfsynproxy.c uses them as well
---
 extensions/libxt_TCPOPTSTRIP.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/extensions/libxt_TCPOPTSTRIP.c b/extensions/libxt_TCPOPTSTRIP.c
index 6897857..1617081 100644
--- a/extensions/libxt_TCPOPTSTRIP.c
+++ b/extensions/libxt_TCPOPTSTRIP.c
@@ -7,11 +7,14 @@
 #include <stdio.h>
 #include <string.h>
 #include <xtables.h>
-#include <netinet/tcp.h>
 #include <linux/netfilter/xt_TCPOPTSTRIP.h>
-#ifndef TCPOPT_MD5SIG
-#	define TCPOPT_MD5SIG 19
-#endif
+
+#define TCPOPT_MAXSEG 2
+#define TCPOPT_WINDOW 3
+#define TCPOPT_SACK_PERMITTED 4
+#define TCPOPT_SACK 5
+#define TCPOPT_TIMESTAMP 8
+#define TCPOPT_MD5SIG 19
 
 enum {
 	O_STRIP_OPTION = 0,
-- 
2.3.6

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.