Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAK1hOcO-YYjtPvgJO_DwfE0_t+EwYSxc4T+129Cg2i9sQAYh6A@mail.gmail.com>
Date: Tue, 24 Feb 2015 04:06:06 +0100
From: Denys Vlasenko <vda.linux@...glemail.com>
To: Rich Felker <dalias@...c.org>
Cc: musl <musl@...ts.openwall.com>
Subject: Re: Draft of improved memset.s for i386

On Tue, Feb 24, 2015 at 4:02 AM, Denys Vlasenko
<vda.linux@...glemail.com> wrote:
> On Tue, Feb 24, 2015 at 2:09 AM, Rich Felker <dalias@...c.org> wrote:
>>   mov %edi,12(%esp)
>
> Shouldn't this be "mov 12(%esp),%edi"?
> It's a load of dst pointer from stack, right?

Erm... no it is not, 12(%esp) is size param.

Looks like this insn serves no purpose?
This will simply trash size param on stack,
since %edi is not initialized.

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.