Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAK1hOcN0EaHwzH+LdnNntM1=3-rnHY-hotY1RBD0xB0qeb1SxQ@mail.gmail.com>
Date: Tue, 24 Feb 2015 04:02:09 +0100
From: Denys Vlasenko <vda.linux@...glemail.com>
To: Rich Felker <dalias@...c.org>
Cc: musl <musl@...ts.openwall.com>
Subject: Re: Draft of improved memset.s for i386

On Tue, Feb 24, 2015 at 2:09 AM, Rich Felker <dalias@...c.org> wrote:
>   mov %edi,12(%esp)

Shouldn't this be "mov 12(%esp),%edi"?
It's a load of dst pointer from stack, right?

>   mov $0x01010101,%edx
>   imul %edx,%eax

I think you can just use "imul $0x01010101,%eax" instead.

(We can't use this form of imul in 64-bit code
since its immediate operand can't be 64-bit wide).

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.