[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1381127894.6107.59.camel@eris.loria.fr>
Date: Mon, 07 Oct 2013 08:38:14 +0200
From: Jens Gustedt <jens.gustedt@...ia.fr>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] getcwd: Set errno to EINVAL when size == 0
Hello,
Am Sonntag, den 06.10.2013, 23:08 -0700 schrieb Michael Forney:
> According to POSIX,
>
> The getcwd() function shall fail if:
>
> [EINVAL]
> The size argument is 0.
> [ERANGE]
> The size argument is greater than 0, but is smaller than the length
> of the string +1.
> ---
> src/unistd/getcwd.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/unistd/getcwd.c b/src/unistd/getcwd.c
> index 2e540cd..0238fa7 100644
> --- a/src/unistd/getcwd.c
> +++ b/src/unistd/getcwd.c
> @@ -8,6 +8,10 @@ char *getcwd(char *buf, size_t size)
> {
> char tmp[PATH_MAX];
> if (!buf) buf = tmp, size = PATH_MAX;
> + else if (size == 0) {
> + errno = EINVAL;
> + return 0;
> + }
> if (syscall(SYS_getcwd, buf, size) < 0) return 0;
Is the new error check really necessary? I would have expected the
error path to have triggered before when buf is !0 and size is 0 on
entry.
> return buf == tmp ? strdup(buf) : buf;
This in turn doesn't seem to be consistent with the extension that
glibc offers. It says
> In this case, the allocated buffer has the length size
So I would think that strdup(buf) should be replaced by something like
strcpy(malloc(size), buf)
Jens
--
:: INRIA Nancy Grand Est :: http://www.loria.fr/~gustedt/ ::
:: AlGorille ::::::::::::::: office Nancy : +33 383593090 ::
:: ICube :::::::::::::: office Strasbourg : +33 368854536 ::
:: ::::::::::::::::::::::::::: gsm France : +33 651400183 ::
:: :::::::::::::::::::: gsm international : +49 15737185122 ::
Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
