Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1381126104-24579-1-git-send-email-mforney@mforney.org>
Date: Sun,  6 Oct 2013 23:08:24 -0700
From: Michael Forney <mforney@...rney.org>
To: musl@...ts.openwall.com
Subject: [PATCH] getcwd: Set errno to EINVAL when size == 0

According to POSIX,

    The getcwd() function shall fail if:

    [EINVAL]
    The size argument is 0.
    [ERANGE]
    The size argument is greater than 0, but is smaller than the length
    of the string +1.
---
 src/unistd/getcwd.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/unistd/getcwd.c b/src/unistd/getcwd.c
index 2e540cd..0238fa7 100644
--- a/src/unistd/getcwd.c
+++ b/src/unistd/getcwd.c
@@ -8,6 +8,10 @@ char *getcwd(char *buf, size_t size)
 {
 	char tmp[PATH_MAX];
 	if (!buf) buf = tmp, size = PATH_MAX;
+	else if (size == 0) {
+		errno = EINVAL;
+		return 0;
+	}
 	if (syscall(SYS_getcwd, buf, size) < 0) return 0;
 	return buf == tmp ? strdup(buf) : buf;
 }
-- 
1.8.4

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.