Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20121008233307.GP254@brightrain.aerifal.cx>
Date: Mon, 8 Oct 2012 19:33:07 -0400
From: Rich Felker <dalias@...ifal.cx>
To: musl@...ts.openwall.com
Subject: Re: Clash between 'netinet/if_ether.h' and 'linux/if_ether.h'

On Tue, Oct 09, 2012 at 12:45:17AM +0200, Abdoulaye Walsimou GAYE wrote:
> Hello,
> While trying to compile busybox-1.20.2, the following issue raised:
> 
>   CC      networking/ifplugd.o
> In file included from /home/walsimou/embtoolkit.git/sysroot-armel-linux-arm920t/usr/include/net/ethernet.h:10:0,
>                  from networking/ifplugd.c:41:
> /home/walsimou/embtoolkit.git/sysroot-armel-linux-arm920t/usr/include/netinet/if_ether.h:75:8: error: redefinition of 'struct ethhdr'
> /home/walsimou/embtoolkit.git/sysroot-armel-linux-arm920t/usr/include/linux/if_ether.h:127:8: note: originally defined here
> 
> Note that uClibc strategy here is to include linux/if_ether.h

It's a bug to be including linux/if_ether.h, and there's no way to
work around this without depending on kernel headers, which musl will
not do for two reasons:

1. We can't control conformance issues and/or breakage if they expose
crap into the namespace that they shouldn't be exposing, and this
tends to vary by version.

2. It makes it so you can't build or use musl without kernel headers.

It should be a one-line patch to fix ifplugd.

Rich

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.