Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110803170406.GP29562@port70.net>
Date: Wed, 3 Aug 2011 19:04:07 +0200
From: Szabolcs Nagy <nsz@...t70.net>
To: musl@...ts.openwall.com
Subject: cluts comments

i've reported these on irc, but luka was not there
so before i forget:

alloc.c:127: WEXITSTAUS(stat) used after !WIFEXITED(stat)

alloc.c should include signal.h (it uses sigaction)

alloc.c does not compile with glibc here
it seems _POSIX_C_SOURCE is not enough for
glibc to have SA_NODEFER in signal.h
i guess that's a glibc bug..

i've seen mixed use of %i and %d in printf
i had to look up the difference (nothing)
i recommend using only one of them consistently
(i prefer %d)

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.