[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20110714185601.GM16618@brightrain.aerifal.cx>
Date: Thu, 14 Jul 2011 14:56:01 -0400
From: Rich Felker <dalias@...ifal.cx>
To: musl@...ts.openwall.com
Subject: Re: cluts review
On Wed, Jul 13, 2011 at 06:55:01PM +0200, Luka Marčetić wrote:
> >I got lots of errors from "numeric" - I didn't bother recording most.
> >The above are just a few of them.
>
> In my opinion, the errors are warranted. But I asked Rich for review
I'm a bit confused by this one:
strtoumax("0xX", &endptr) should return 0, errno=0(Invalid error number)
instead, it returns 0, errno=EINVAL
Why do you expect it to return with errno=0? Since the subject
sequence does not have a correct form, I believe the implementation
may (and should, from a quality of implementation standpoint) set
errno to EINVAL. Of course a portable application will need to examine
endptr instead of errno to check this case.
The remaining errors all seem correct. It's expected that glibc fails
lots of these tests. See:
http://sourceware.org/bugzilla/show_bug.cgi?id=12701
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
