libc-coord - Re: [PATCH v4] off64_t: prefer off

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d36e6b2-57be-148e-a6fa-d7734279671d@kernel.org>
Date: Sat, 15 Jul 2023 17:08:18 +0200
From: Alejandro Colomar <alx@...nel.org>
To: Paul Eggert <eggert@...ucla.edu>, Sam James <sam@...too.org>,
 Rich Felker <dalias@...c.org>, libc-coord@...ts.openwall.com,
 linux-man@...r.kernel.org
Cc: "A . Wilcox" <AWilcox@...cox-tech.com>,
 Jonathan Wakely <jwakely@...hat.com>, libc-alpha@...rceware.org,
 musl@...ts.openwall.com, Szabolcs Nagy <nsz@...t70.net>,
 Jakub Wilk <jwilk@...lk.net>
Subject: Re: [PATCH v4] off64_t: prefer off_t for splice, etc.

Hi Paul, Sam, and Rich,

On 2023-07-09 08:16, Sam James wrote:
> 
> Paul Eggert <eggert@...ucla.edu> writes:
> 
>> For the few functions that come only in 64-bit off_t flavors,
>> document their APIs as using off_t instead of off64_t,
>> and say also that code should #define _FILE_OFFSET_BITS 64.
>> This documents what user code is (and should be) doing anyway,
>> if it needs to work on traditional x86 and ARM Linux.
> 
> LGTM and thank you Paul.
> 
> I haven't checked for other prototypes/examples which need
> changing.

Thanks, I'm going to apply the patch.  Can you please confirm if I'm
correct in adding the following tags?

    Reported-by: Rich Felker <dalias@...c.org>
    Fixes: 9bebb17e5b57 ("splice.2: Use 'off64_t' instead of 'loff_t'")
    Fixes: 76c5631fb442 ("copy_file_range.2: Document glibc wrapper instead of kernel syscall")
    Fixes: 5cabfa06b407 ("man-pages 1.68")
    Fixes: 3ca974e3988a ("New page for sync_file_range(2), new in kernel 2.6.17.")
    Fixes: 9bebb17e5b57 ("sync_file_range.2: Document the architecture-specific sync_file_range2() system call")
    Fixes: 79bf8cdcf36a ("Document fopencookie(3), a library function that allows custom implementation of a stdio stream.")
    Signed-off-by: Paul Eggert <eggert@...ucla.edu>
    Reviewed-by: Sam James <sam@...too.org>
    Cc: Jonathan Wakely <jwakely@...hat.com>
    Cc: Szabolcs Nagy <nsz@...t70.net>
    Cc: Jakub Wilk <jwilk@...lk.net>
    Cc: A. Wilcox <AWilcox@...cox-tech.com>
    Signed-off-by: Alejandro Colomar <alx@...nel.org>

BTW, Rich, please note the commits that this fixes: most of them are
the initial commit that adds a page, which means that the function
had always been documented with off64_t in the "spec".  Only splice(2)
and copy_file_range(2) have been adjusted afterwards, and in a manner
to be consistent with the rest of the pages, so I can only conclude
that we didn't break the spec, but rather fixed it.

Nevertheless, I'm sorry that it caused any problems to musl, and I'm
happy that you reported them and so we can now improve the pages.

Cheers,
Alex

-- 
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (834 bytes)

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.