[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CABgxDoLZKbrzghbp09kraEsk0iLzn7B0BEQWmZcdrXwmOu_MKw@mail.gmail.com>
Date: Tue, 23 Feb 2021 10:31:15 +0100
From: Romain Perier <romain.perier@...il.com>
To: Shuah Khan <skhan@...uxfoundation.org>
Cc: Kees Cook <keescook@...omium.org>,
Kernel Hardening <kernel-hardening@...ts.openwall.com>, Tejun Heo <tj@...nel.org>,
Zefan Li <lizefan.x@...edance.com>, Johannes Weiner <hannes@...xchg.org>,
Herbert Xu <herbert@...dor.apana.org.au>, "David S. Miller" <davem@...emloft.net>,
Jiri Pirko <jiri@...dia.com>, Sumit Semwal <sumit.semwal@...aro.org>,
Christian König <christian.koenig@....com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Mimi Zohar <zohar@...ux.ibm.com>,
Dmitry Kasatkin <dmitry.kasatkin@...il.com>, "J. Bruce Fields" <bfields@...ldses.org>,
Chuck Lever <chuck.lever@...cle.com>, Geert Uytterhoeven <geert@...ux-m68k.org>,
Jessica Yu <jeyu@...nel.org>, Guenter Roeck <linux@...ck-us.net>, Heiko Carstens <hca@...ux.ibm.com>,
Vasily Gorbik <gor@...ux.ibm.com>, Christian Borntraeger <borntraeger@...ibm.com>,
Steffen Maier <maier@...ux.ibm.com>, Benjamin Block <bblock@...ux.ibm.com>,
"Martin K. Petersen" <martin.petersen@...cle.com>, Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>, Steven Rostedt <rostedt@...dmis.org>, Ingo Molnar <mingo@...hat.com>,
Jiri Slaby <jirislaby@...nel.org>, Felipe Balbi <balbi@...nel.org>,
Valentina Manea <valentina.manea.m@...il.com>, Shuah Khan <shuah@...nel.org>,
Wim Van Sebroeck <wim@...ux-watchdog.org>, cgroups@...r.kernel.org,
linux-crypto@...r.kernel.org, netdev <netdev@...r.kernel.org>,
linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org,
linaro-mm-sig@...ts.linaro.org, "Rafael J. Wysocki" <rafael@...nel.org>,
linux-integrity@...r.kernel.org, linux-nfs@...r.kernel.org,
linux-m68k@...ts.linux-m68k.org, linux-hwmon@...r.kernel.org,
linux-s390@...r.kernel.org, linux-scsi@...r.kernel.org,
target-devel@...r.kernel.org, alsa-devel@...a-project.org,
linux-usb@...r.kernel.org, linux-watchdog@...r.kernel.org,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 00/20] Manual replacement of all strlcpy in favor of strscpy
Le lun. 22 févr. 2021 à 17:36, Shuah Khan <skhan@...uxfoundation.org> a
écrit :
>
> Cool. A quick check shows me 1031 strscpy() calls with no return
> checks. All or some of these probably need to be reviewed and add
> return checks. Is this something that is in the plan to address as
> part of this work?
>
> thanks,
> -- Shuah
>
Hi,
Initially, what we planned with Kees is to firstly replace all calls with
error handling codes (like this series does),
and then replace all other simple calls (without error handling). However,
we can also start a discussion about this topic, all suggestions are
welcome.
I am not sure that it does make sense to check all returns code in all
cases (for example in arch/alpha/kernel/setup.c, there are a ton of other
examples in the kernel). But a general review (as you suggest), would make
sense.
Regards,
Romain
Content of type "text/html" skipped
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
