[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210222165623.12e31597@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date: Mon, 22 Feb 2021 16:56:23 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Romain Perier <romain.perier@...il.com>
Cc: Kees Cook <keescook@...omium.org>, kernel-hardening@...ts.openwall.com,
Jiri Pirko <jiri@...dia.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/20] devlink: Manual replacement of the deprecated
strlcpy() with return values
On Mon, 22 Feb 2021 16:12:14 +0100 Romain Perier wrote:
> diff --git a/net/core/devlink.c b/net/core/devlink.c
> index 737b61c2976e..7eb445460c92 100644
> --- a/net/core/devlink.c
> +++ b/net/core/devlink.c
> @@ -9461,10 +9461,10 @@ EXPORT_SYMBOL_GPL(devlink_port_param_value_changed);
> void devlink_param_value_str_fill(union devlink_param_value *dst_val,
> const char *src)
> {
> - size_t len;
> + ssize_t len;
>
> - len = strlcpy(dst_val->vstr, src, __DEVLINK_PARAM_MAX_STRING_VALUE);
> - WARN_ON(len >= __DEVLINK_PARAM_MAX_STRING_VALUE);
> + len = strscpy(dst_val->vstr, src, __DEVLINK_PARAM_MAX_STRING_VALUE);
> + WARN_ON(len == -E2BIG);
WARN_ON(len < 0) ?
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
