|
Message-ID: <201907221017.F61AFC08E@keescook> Date: Mon, 22 Jul 2019 10:19:15 -0700 From: Kees Cook <keescook@...omium.org> To: Romain Perier <romain.perier@...il.com> Cc: Kernel Hardening <kernel-hardening@...ts.openwall.com>, Shyam Saini <mayhs11saini@...il.com> Subject: Re: refactor tasklets to avoid unsigned long argument On Sun, Jul 21, 2019 at 07:55:33PM +0200, Romain Perier wrote: > Ok, thanks for these explanations. (Reminder: please use inline-context email replies instead of top-posting, this makes threads much easier to read.) > The task is in progress, you can follow the status here : > https://salsa.debian.org/rperier-guest/linux-tree/tree/tasklet_init > (the commit messages are tagged WIP, I will add a long message and > signed-off-by , when it's done) Looks good! I wonder if you're able to use Coccinelle to generate the conversion patch? There appear to be just under 400 callers of tasklet_init(), which is a lot to type by hand. :) Also, have you found any other tasklet users that are NOT using tasklet_init()? The timer_struct conversion had about three ways to do initialization. :( -- Kees Cook
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.