[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190209060135.GA1389@eros.localdomain>
Date: Sat, 9 Feb 2019 17:01:35 +1100
From: "Tobin C. Harding" <me@...in.cc>
To: Tycho Andersen <tycho@...ho.ws>
Cc: "Tobin C. Harding" <tobin@...nel.org>,
kernel-hardening@...ts.openwall.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] leaking_addresses: Expand tilde in output file name
On Thu, Feb 07, 2019 at 04:35:55PM -0700, Tycho Andersen wrote:
> On Fri, Feb 08, 2019 at 09:50:26AM +1100, Tobin C. Harding wrote:
> > Currently if user passes an output file to the script via
> > --output-raw we do not handle expansion of tilde.
> >
> > Use perl function glob() to expand tilde in output file name.
> >
> > Signed-off-by: Tobin C. Harding <tobin@...nel.org>
> > ---
> > scripts/leaking_addresses.pl | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
> > index ef9e5b2a1614..ce545ca3fb70 100755
> > --- a/scripts/leaking_addresses.pl
> > +++ b/scripts/leaking_addresses.pl
> > @@ -150,7 +150,7 @@ if (!(is_supported_architecture() or $opt_32bit or $page_offset_32bit)) {
> > }
> >
> > if ($output_raw) {
> > - open my $fh, '>', $output_raw or die "$0: $output_raw: $!\n";
> > + open my $fh, '>', glob($output_raw) or die "$0: $output_raw: $!\n";
>
> Seems like you might also have the same problem with $input_raw? I
> wonder if you can just do this in GetOptions somehow, so that all
> users of these further down in the script don't have to remember to do
> this.
Thanks for the review, good idea - I'll look into it.
Tobin
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
