[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180327023110.GD10054@bombadil.infradead.org>
Date: Mon, 26 Mar 2018 19:31:10 -0700
From: Matthew Wilcox <willy@...radead.org>
To: Igor Stoppa <igor.stoppa@...wei.com>
Cc: keescook@...omium.org, mhocko@...nel.org, david@...morbit.com,
rppt@...ux.vnet.ibm.com, labbott@...hat.com,
linux-security-module@...r.kernel.org, linux-mm@...ck.org,
linux-kernel@...r.kernel.org, kernel-hardening@...ts.openwall.com,
igor.stoppa@...il.com
Subject: Re: [PATCH 3/6] Protectable Memory
On Tue, Mar 27, 2018 at 04:55:21AM +0300, Igor Stoppa wrote:
> +static inline void *pmalloc_array_align(struct pmalloc_pool *pool,
> + size_t n, size_t size,
> + short int align_order)
> +{
You're missing:
if (size != 0 && n > SIZE_MAX / size)
return NULL;
> + return pmalloc_align(pool, n * size, align_order);
> +}
> +static inline void *pcalloc_align(struct pmalloc_pool *pool, size_t n,
> + size_t size, short int align_order)
> +{
> + return pzalloc_align(pool, n * size, align_order);
> +}
Ditto.
> +static inline void *pcalloc(struct pmalloc_pool *pool, size_t n,
> + size_t size)
> +{
> + return pzalloc_align(pool, n * size, PMALLOC_ALIGN_DEFAULT);
> +}
If you make this one:
return pcalloc_align(pool, n, size, PMALLOC_ALIGN_DEFAULT)
then you don't need the check in this function.
Also, do we really need 'align' as a parameter to the allocator functions
rather than to the pool?
I'd just reuse ARCH_KMALLOC_MINALIGN from slab.h as the alignment, and
then add the special alignment options when we have a real user for them.
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
