[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ce6e34a4-592d-624c-2353-20e50e321298@huawei.com>
Date: Sun, 25 Mar 2018 04:32:57 +0300
From: Igor Stoppa <igor.stoppa@...wei.com>
To: Matthew Wilcox <willy@...radead.org>
CC: <david@...morbit.com>, <rppt@...ux.vnet.ibm.com>, <keescook@...omium.org>,
<mhocko@...nel.org>, <labbott@...hat.com>,
<linux-security-module@...r.kernel.org>, <linux-mm@...ck.org>,
<linux-kernel@...r.kernel.org>, <kernel-hardening@...ts.openwall.com>
Subject: Re: [PATCH 6/8] Pmalloc selftest
On 14/03/18 14:25, Matthew Wilcox wrote:
> On Tue, Mar 13, 2018 at 11:45:52PM +0200, Igor Stoppa wrote:
>> Add basic self-test functionality for pmalloc.
>
> Here're some additional tests for your test-suite:
>
> for (i = 1; i; i *= 2)
> pzalloc(pool, i - 1, GFP_KERNEL);
>
Ok, I have almost finished the rewrite.
I still have to address this comment.
When I run the test, eventually the system runs out of memory, it keeps
getting allocation errors from vmalloc, until i finally overflows and
becomes 0.
Am I supposed to do something about it?
If pmalloc receives a request that the vmalloc backend cannot satisfy, I
would prefer that vmalloc itself produces the warning and pmalloc
returns NULL.
This doesn't look like a test case that one can leave always enabled in
a build, but maybe I'm missing the point.
--
igor
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
